<table><tr><td style="">ivan updated this revision to Diff 12098.<br />ivan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3805" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I need help with this one.</p>

<p>I've temporarily added ModelTest and two QListViews to show the contents of the models.</p>

<p>KActivities::Stats::ResultModel has no problems according to both the ModelTest and the QListView it is shown in.</p>

<p>KAStatsFavoritesModel (placeholdermodel.cpp and kastatsfavoritesmodel.cpp) have a problem.</p>

<p>ModelTest does not give any meaningful message.</p>

<p>And the dashboard and the QListView show different data. Namely, if you try to add a new item not via drag and drop, but right-click and assign to current activity, the dashboard starts showing a few empty elements on the end of the model.</p>

<p>Addin via d-n-d does not seem to have the same problem. I've even tried simulating d-n-d adding when index is -1, but with no success.</p>

<p>I don't see where the problem is at the moment.</p></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3805?vs=9360&id=12098" rel="noreferrer">https://phabricator.kde.org/D3805?vs=9360&id=12098</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3805" rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
applets/kicker/CMakeLists.txt<br />
applets/kicker/package/contents/code/tools.js<br />
applets/kicker/package/contents/ui/ActionMenu.qml<br />
applets/kicker/plugin/computermodel.cpp<br />
applets/kicker/plugin/computermodel.h<br />
applets/kicker/plugin/favoritesmodel.cpp<br />
applets/kicker/plugin/favoritesmodel.h<br />
applets/kicker/plugin/kastatsfavoritesmodel.cpp<br />
applets/kicker/plugin/kastatsfavoritesmodel.h<br />
applets/kicker/plugin/kickerplugin.cpp<br />
applets/kicker/plugin/modeltest.cpp<br />
applets/kicker/plugin/modeltest.h<br />
applets/kicker/plugin/placeholdermodel.cpp<br />
applets/kicker/plugin/placeholdermodel.h<br />
applets/kicker/plugin/recentusagemodel.cpp<br />
applets/kicker/plugin/rootmodel.cpp<br />
applets/kicker/plugin/rootmodel.h<br />
applets/kicker/plugin/simplefavoritesmodel.cpp<br />
applets/kicker/plugin/simplefavoritesmodel.h<br />
applets/kicker/plugin/systemmodel.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>ivan, mart, hein<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>