<table><tr><td style="">subdiff accepted this revision.<br />subdiff added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4837" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4837#inline-19539" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:123</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                        <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.maximumHeight:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">slider</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">height</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0.85</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                        <span style="color: #aa4000">Layout.<span class="bright">maximum</span>Width:</span> <span style="color: #004012">slider</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.<span class="bright">85</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span class="bright"></span><span style="color: #aa4000"><span class="bright">roundToIconSize:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span style="color: #aa4000">Layout.<span class="bright">preferred</span>Width:</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">Math</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">round</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">slider</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.<span class="bright">95</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span style="color: #aa4000">Layout.preferredHeight:</span> <span style="color: #004012">Layout</span><span class="p">.</span><span style="color: #004012">preferredWidth</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why still the 0.95? Couldn't you just use the slider height? It's still a little bit small for the microphone icon (especially showing the red line above as the difference between muted and unmuted)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>applet-indicator-size (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4837" rel="noreferrer">https://phabricator.kde.org/D4837</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, subdiff<br /><strong>Cc: </strong>subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>