<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4751" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19196" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:135</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">How does it break accessibility?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ul class="remarkup-list">
<li class="remarkup-list-item">Missing <tt style="background: #ebebeb; font-size: 13px;">Accessible</tt></li>
<li class="remarkup-list-item">Cannot be tabbed to</li>
<li class="remarkup-list-item">Doesn't have a proper hover effect</li>
<li class="remarkup-list-item">Has no tooltip</li>
</ul>

<p style="padding: 0; margin: 8px;">etc etc</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19203" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:145</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                            <span style="color: #aa4000">onClicked:</span> <span style="color: #004012">contextMenu</span><span class="p">.</span><span style="color: #004012">show</span><span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">x</span><span class="p">,</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211">+</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                            <span style="color: #aa4000">onEntered:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">opacity</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0.8</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                            <span style="color: #aa4000">onExited:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">opacity</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't mess with the opacity, use the <tt style="background: #ebebeb; font-size: 13px;">active</tt> property on <tt style="background: #ebebeb; font-size: 13px;">IconItem</tt> which will have <tt style="background: #ebebeb; font-size: 13px;">KIconLoader</tt> use the correct hover state (you could have configured it to tint the icon instead etc)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19204" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">var</span> <span style="color: #004012">menuItem</span> <span style="color: #aa2211">=</span> <span style="color: #004012">newMenuItem</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">=</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Default"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">checkable</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please add some context for translators</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4751" rel="noreferrer">https://phabricator.kde.org/D4751</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>subdiff, Plasma, drosca, Zren<br /><strong>Cc: </strong>broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>