<table><tr><td style="">drosca added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4751" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19150" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span style="color: #aa4000">source:</span> <span style="color: #766510">"application-menu"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span style="color: #aa4000">Layout.maximumHeight:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.85</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span style="color: #aa4000">Layout.maximumWidth:</span> <span style="color: #004012">Layout</span><span class="p">.</span><span style="color: #004012">maximumHeight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use Layout.preferredHeight instead of maximumHeight.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19151" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                            <span style="color: #aa4000">onReleased:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">opacity</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                            <span style="color: #aa4000">onCanceled:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">opacity</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">parent.opacity: mouseArea.containsMouse ? 0.8 : 1.0</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19152" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:264</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">checkable</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">true</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">checked</span> <span style="color: #aa2211">=</span> <span style="color: #004012">PulseObject</span><span class="p">.</span><span style="color: #004012">muted</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">menuItem</span><span class="p">.</span><span style="color: #004012">clicked</span><span class="p">.</span><span style="color: #004012">connect</span><span class="p">(</span><span style="color: #aa4000">function</span><span class="p">()</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I know it was like that in the original code, but please rewrite it to use directly the properties (<tt style="background: #ebebeb; font-size: 13px;">Muted</tt> in this case) instead of accessing it through <tt style="background: #ebebeb; font-size: 13px;">PulseObject</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19153" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:283</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #74777d">// Ports</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">PulseObject</span><span class="p">.</span><span style="color: #004012">ports</span> <span style="color: #aa2211">&&</span> <span style="color: #601200">0</span> <span style="color: #aa2211"><</span> <span style="color: #004012">PulseObject</span><span class="p">.</span><span style="color: #004012">ports</span><span class="p">.</span><span style="color: #004012">length</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">contextMenu</span><span class="p">.</span><span style="color: #004012">addMenuItem</span><span class="p">(</span><span style="color: #004012">newSeperator</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please move literal to right side of comparison: <tt style="background: #ebebeb; font-size: 13px;">PulseObject.ports.length > 0</tt> or even in this case you can just write <tt style="background: #ebebeb; font-size: 13px;">PulseObject.ports.length</tt>.</p>

<p style="padding: 0; margin: 8px;">But actually make it <tt style="background: #ebebeb; font-size: 13px;">Ports.length</tt> as said in previous comment.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4751#inline-19155" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ListItemBase.qml:316</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #004012">MouseArea</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">acceptedButtons:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">RightButton</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If we now have a button for showing this menu, I think we can completely remove the right click context menu.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4751" rel="noreferrer">https://phabricator.kde.org/D4751</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>subdiff, Plasma, Zren, drosca<br /><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>