<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4614" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>looks sensible.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4614#inline-18505" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Messages.sh:6</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">$XGETTEXT <span style="color: #766510">`</span>find . -name <span style="color: #bb6622">\*</span>.cc -o -name <span style="color: #bb6622">\*</span>.cpp -o -name <span style="color: #bb6622">\*</span>.h -o -name <span style="color: #bb6622">\*</span>.qml <span class="p">|</span> grep -v <span style="color: #766510">"/src/filepropertiesplugin/"</span><span style="color: #766510">`</span> -o $podir/baloowidgets.pot
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is this not overwriting the generated extraction above?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4614#inline-18507" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">baloofilepropertiesplugin.cpp:50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">auto</span> <span style="color: #aa2211">*</span><span class="n">metaDataWidget</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">Baloo</span><span style="color: #aa2211">::</span><span class="n">FileMetaDataWidget</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">metaDataWidget</span><span style="color: #aa2211">-></span><span class="n">setItems</span><span class="p">(</span><span class="n">properties</span><span style="color: #aa2211">-></span><span class="n">items</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would argue that the FileMetaDataWidget should have the spacer on the end of it's own grid layout. A widget should be able to handle being resized gracefully without making every containing app do it.</p>

<p style="padding: 0; margin: 8px;">(but I don't super object to this either. If this were on RB, imagine I haven't checked the "Open an Issue" checkbox)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4614#inline-18506" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">baloofilepropertiesplugin.desktop:8</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">X-KDE-Protocol=file
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">X-KDE-ServiceTypes=KPropertiesDialog/Plugin,image/jp2,image/jpeg,image/pgf,image/png,image/tiff,image/x-exv,image/x-canon-cr2,image/x-canon-crw,image/x-fuji-raf,image/x-minolta-mrw,image/x-nikon-nef,image/x-olympus-orf,image/x-panasonic-rw2,image/x-pentax-pef,image/x-photoshop,image/x-samsung-srw,video/x-ms-asf,video/x-msvideo,video/x-flv,video/quicktime,video/mpeg,video/x-ms-wmv,video/mp4,video/x-matroska,video/webm,application/x-mobipocket-ebook,application/vnd.oasis.opendocument.text,application/vnd.oasis.opendocument.presentation,application/vnd.oasis.opendocument.spreadsheet,application/vnd.openxmlformats-officedocument.wordprocessingml.document,application/vnd.openxmlformats-officedocument.presentationml.presentation,application/vnd.openxmlformats-officedocument.spreadsheetml.sheet,application/msword,application/vnd.ms-excel,application/vnd.ms-powerpoint,text/plain,text/richtext,text/x-gettext-translation,application/pdf,audio/mpeg,audio/mpeg3,audio/x-mpeg,audio/mp4,audio/flac,audio/x-musepack,audio/ogg,audio/x-vorbis+ogg,audio/opus,audio/x-opus+ogg,audio/wav,audio/x-aiff,audio/x-ape,audio/x-wavpack
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">where does this list come from?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R824 Baloo Widgets</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4614" rel="noreferrer">https://phabricator.kde.org/D4614</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, dfaure, aacid<br /><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>