<table><tr><td style="">subdiff accepted this revision.<br />subdiff added a reviewer: subdiff.<br />subdiff added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4578" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Didn't find any obvious issues in code plus tested it on X and Wayland.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4578#inline-18376" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">keyboard_input.cpp:686</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_input</span><span style="color: #aa2211">-></span><span class="n">processSpies</span><span class="p">(</span><span class="n">std</span><span style="color: #aa2211">::</span><span class="n">bind</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">InputEventSpy</span><span style="color: #aa2211">::</span><span class="n">keyEvent</span><span class="p">,</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">placeholders</span><span style="color: #aa2211">::</span><span class="n">_1</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">event</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_inited</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Somewhat unrelated to this diff, but can't we get rid of all these <tt style="background: #ebebeb; font-size: 13px;">m_inited</tt> conditions by setting up LibInput via <tt style="background: #ebebeb; font-size: 13px;">InputRedirection::setupLibInput()</tt> and connecting the functions in KeyboardInputRedirection only after <tt style="background: #ebebeb; font-size: 13px;">m_keyboard->init()</tt> and so on in <tt style="background: #ebebeb; font-size: 13px;">InputRedirection::setupWorkspace()</tt> were called?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>modifier-only-shortcuts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4578" rel="noreferrer">https://phabricator.kde.org/D4578</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, KWin, subdiff<br /><strong>Cc: </strong>subdiff, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>