<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127616/">https://git.reviewboard.kde.org/r/127616/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 12:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=360059">360059</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is mostly a refactoring, removing a lot of update functions and making use of QtQuick's event-driven update logic instead.
It leads to a lot less updates and a much easier to understand code.
All the formatting and update functions have been reduced to what's necessary in oder to save some cpu time.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The layout has been refactored as well leading to some small changes:
- The time label is now vertically centered without an offset
- The size of the calendar has been reduced slightly
- Labels can't have multiple lines in vertical panels any more
- The timezone and date labels have been reduced to 2/3 of the time label size</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The options in the config dialog have been re-ordered.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And a new feature has been implemented:
- Seconds are always shown in the tooltip</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And some more changes:
- If the dates of time zones differ from the currently active time zone, the full date is shown for these time zones in the tooltip
(Currently the full date is shown for time zones if their dates differ from the local time zone)
- Always use font.pointSize in order to get rid of pointSize vs. pixelSize warnings</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with different configurations.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/config/config.qml <span style="color: grey">(877e40c)</span></li>
<li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: grey">(381bddb)</span></li>
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: grey">(02d55a9)</span></li>
<li>applets/digital-clock/package/contents/ui/MonthMenu.qml <span style="color: grey">(170ce62)</span></li>
<li>applets/digital-clock/package/contents/ui/Tooltip.qml <span style="color: grey">(2a8dda9)</span></li>
<li>applets/digital-clock/package/contents/ui/configAppearance.qml <span style="color: grey">(fc9a09e)</span></li>
<li>applets/digital-clock/package/contents/ui/configTimeZones.qml <span style="color: grey">(3ac84a7)</span></li>
<li>applets/digital-clock/package/contents/ui/main.qml <span style="color: grey">(b86b7fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127616/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/d2fd6bfc-2f24-417f-a873-bc0683f6873d__clock-tooltip.png">Old clock on the left, new one on the right</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/4edaa035-0e69-4af2-885d-59e311ac5ac2__clock-tooltip-multi-tz.png">Tooltip with multiple time zones, current date differs from local tz date</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/8ca78bd7-f82d-4cfa-b919-60b713d5c557__clock-config-old.png">Old config dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/a69b5256-9353-40c8-989b-05575f07c15b__clock-config-new.png">New config dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>