<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4343" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Neat!</p>
<p>I do get a bunch of warnings on startup, though:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">
file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:244:17: QML Text: Binding loop detected for property "width"</pre></div>
<p>Spring-loading when dragging a file ontop of a folder no longer works (didn't see any obvious warnings on console)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17330" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">status</span> <span style="color: #aa2211">==</span> <span style="color: #004012">Loader</span><span class="p">.</span><span style="color: #004012">Ready</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">===</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17331" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">asynchronous:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I ran into quite some trouble (layouts, crashes, glitches) with async loaders in an item view, you said it didn't help anyways, so perhaps we can try without?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17332" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">Item</span> <span style="color: #aa4000">label:</span> <span style="color: #004012">label</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #004012">property</span> <span style="color: #004012">Item</span> <span style="color: #aa4000">labelArea:</span> <span style="color: #004012">textShadow</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">property</span> <span style="color: #004012">Item</span> <span style="color: #aa4000">labelArea:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">frameLoader</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">textShadow</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">frameLoader.</span>textShadow<span class="bright"> :</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">label</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">Item</span> <span style="color: #aa4000">actionsOverlay:</span> <span style="color: #004012">actions</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could be simplified to</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">frameLoader.textShadow || label</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17333" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #004012">frame</span><span class="p">.</span><span style="color: #004012">grabToImage</span><span class="p">(</span><span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">result</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #004012">dir</span><span class="p">.</span><span style="color: #004012">addItemDragImage</span><span class="p">(</span><span style="color: #004012">positioner</span><span class="p">.</span><span style="color: #004012">map</span><span class="p">(</span><span style="color: #004012">index</span><span class="p">),</span> <span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211">+</span> <span style="color: #004012">frame<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">x</span><span class="p">,</span> <span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211">+</span> <span style="color: #004012">frame</span><span class="p">.</span><span style="color: #004012">y</span><span class="p">,</span> <span style="color: #004012">frame</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">frame</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">,</span> <span style="color: #004012">result</span><span class="p">.</span><span style="color: #004012">image</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">frame<span class="bright">Loader</span></span><span class="p">.</span><span style="color: #004012">grabToImage</span><span class="p">(</span><span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">result</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">dir</span><span class="p">.</span><span style="color: #004012">addItemDragImage</span><span class="p">(</span><span style="color: #004012">positioner</span><span class="p">.</span><span style="color: #004012">map</span><span class="p">(</span><span style="color: #004012">index</span><span class="p">),</span> <span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">x</span> <span style="color: #aa2211">+</span> <span style="color: #004012">frame<span class="bright">Loader</span>x</span><span class="p">,</span> <span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">y</span> <span style="color: #aa2211">+</span> <span style="color: #004012">frame<span class="bright">Loader</span></span><span class="p">.</span><span style="color: #004012">y</span><span class="p">,</span> <span style="color: #004012">frame<span class="bright">Loader</span></span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span style="color: #004012">frame<span class="bright">Loader</span></span><span class="p">.</span><span style="color: #004012">height</span><span class="p">,</span> <span style="color: #004012">result</span><span class="p">.</span><span style="color: #004012">image</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo <tt style="background: #ebebeb; font-size: 13px;">frameLoader.x</tt></p>
<p style="padding: 0; margin: 8px;">That's why the drag pixmap doesn't work</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17334" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:120</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">selectionButton</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">null</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QML nulls properties automatically if the item referenced is destroyed but I understand you want this explicitly</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17335" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:177</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">sourceComponent:</span> <span style="color: #004012">frameComponent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">active:</span> <span style="color: #004012">state</span> <span style="color: #aa2211">!=</span> <span style="color: #766510">""</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">asynchronous:</span> <span style="color: #000a65">true</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">!==</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17336" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:292</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"> </span><span style="color: #aa4000">color:</span> <span style="color: #004012">textShadow<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"white"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">PlasmaCore</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ColorScope</span></span><span class="p">.</span><span style="color: #004012">text<span class="bright">Color</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">color:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">frameLoader</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">textShadow<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">frameLoader</span></span><span class="p">.</span><span style="color: #004012">text<span class="bright">Shadow</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa2211">?</span> <span style="color: #766510">"white"</span> <span style="color: #aa2211">:</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Careful with binding things to <tt style="background: #ebebeb; font-size: 13px;">visible</tt>, it updates recursively and may cause unexpected re-evaluations or glitches when the applet popup opens/closes (like the folderview title bug)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4343#inline-17337" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FolderItemDelegate.qml:293</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"> </span><span style="color: #aa4000">color:</span> <span style="color: #004012">textShadow<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"white"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">PlasmaCore</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ColorScope</span></span><span class="p">.</span><span style="color: #004012">text<span class="bright">Color</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">color:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">frameLoader</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">textShadow<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">frameLoader</span></span><span class="p">.</span><span style="color: #004012">text<span class="bright">Shadow</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa2211">?</span> <span style="color: #766510">"white"</span> <span style="color: #aa2211">:</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since we're all about speed here, <tt style="background: #ebebeb; font-size: 13px;">"#fff"</tt> is ~6% faster than <tt style="background: #ebebeb; font-size: 13px;">"white"</tt> :D</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4343" rel="noreferrer">https://phabricator.kde.org/D4343</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>