<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4229" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16909" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:537</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">onClicked:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">tasksModel</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">requestRemoveLauncher</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">get</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">atm</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">LauncherUrlWithoutIcon</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">onClicked:</span> <span class="bright"></span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">console</span><span class="p">.</span><span style="color: #004012">log</span><span class="p">(</span><span style="color: #766510">"unpin request"</span><span class="p">,</span> <span style="color: #004012">modelIndex</span><span class="p">,</span> <span style="color: #004012">get</span><span class="p">(</span><span style="color: #004012">atm</span><span class="p">.</span><span style="color: #004012">LauncherUrlWithoutIcon</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16910" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">console</span><span class="p">.</span><span style="color: #004012">log</span><span class="p">(</span><span style="color: #004012">itemTop</span><span class="p">,</span> <span style="color: #004012">itemBottom</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16911" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:113-114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span class="bright"></span><span style="color: #aa4000"><span class="bright">anchors.fill</span>:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="bright">    </span><span style="color: #aa4000"><span class="bright">width</span>:</span> <span style="color: #004012">parent<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">width</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">height:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why this change?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16912" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:119</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                    <span style="color: #74777d">// transition after setting the model so onTriggered</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                    <span style="color: #74777d">// will run after the Flow has positioned items.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">FTR: Qt 5.9 will add a "positioningComplete" signal :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16913" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #004012">groupRepeater</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #601200">0<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">forceActiveFocus</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="bright"></span><span style="color: #aa4000"><span class="bright">var</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">task</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012">groupRepeater</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">task</span><span class="p">.</span><span style="color: #004012">forceActiveFocus</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">scrollArea</span><span class="p">.</span><span style="color: #004012">ensureItemVisible</span><span class="p">(</span><span style="color: #004012">task</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you perhaps have the task do that automatically since fwict you always do forceActiveFocus and then ensureItemVisible:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">onActiveFocusChanged: {
    if (activeFocus) {
        ensureItemVisible(this);
    }
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16914" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:253</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">i</span> <span style="color: #aa2211"><</span> <span style="color: #004012">taskList</span><span class="p">.</span><span style="color: #004012">children</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">;</span> <span style="color: #aa2211">++</span><span style="color: #004012">i</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">taskList</span><span class="p">.</span><span style="color: #004012">children</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #004012">maxWidth</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4229#inline-16915" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GroupDialog.qml:264</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">Component.onCompleted:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #004012">textMetrics</span> <span style="color: #aa2211">=</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">createQmlObject</span><span class="p">(</span><span style="color: #766510">'import QtQuick 2.7; TextMetrics {}'</span><span class="p">,</span> <span style="color: #004012">groupDialog</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not assign it directly above?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">property TextMetrics textMetrics: TextMetrics {}</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4229" rel="noreferrer">https://phabricator.kde.org/D4229</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>