<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4204" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>That's quite a huge patch.</p>
<p>Can you give a much bigger explanation on exactly what it's doing and why.</p>
<p>"Fixes bug N" doesn't really explain what the original problem was.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4204#inline-16661" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppletAppearance.qml:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">minimumHeight<span class="bright">:</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">Math</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">max</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">layoutManager</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">cellSize</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">height</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #004012">minimumHeight</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">Binding</span> <span style="color: #004012">on</span> <span style="color: #004012">minimumHeight</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do you do</p>
<p style="padding: 0; margin: 8px;">property int foo<br />
Binding on foo {<br />
value: Math.max()<br />
}</p>
<p style="padding: 0; margin: 8px;">instead of just</p>
<p style="padding: 0; margin: 8px;">property int foo: Math.max</p>
<p style="padding: 0; margin: 8px;">?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4204#inline-16662" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppletAppearance.qml:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span style="color: #004012"><span class="bright">KQuickControlsAddons</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">MouseEventListener</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">id: <span class="bright">mouseListener</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #004012"><span class="bright">QtObject</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">id: <span class="bright">d</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Point is a native QML type.<br />
<a href="http://doc.qt.io/qt-5/qml-point.html" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qml-point.html</a></p>
<p style="padding: 0; margin: 8px;">property point lastPoint</p>
<p style="padding: 0; margin: 8px;">then use that in your logic above.<br />
It can be better because you then get one signal when it changes not two.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4204#inline-16663" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AppletAppearance.qml:445</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">var</span> <span style="color: #004012">maxInt</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1000000</span><span class="p">;</span> <span style="color: #74777d">// dirty hack</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">size</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">></span> <span style="color: #004012">maxInt</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">size</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">=</span> <span style="color: #004012">maxInt</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if maximum is infinite, (so undefined in QtQuick.Layouts) set it to 1000000</p>
<p style="padding: 0; margin: 8px;">why?<br />
It's far easier to test for isFinite() in other bits of code than a random big init</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4204" rel="noreferrer">https://phabricator.kde.org/D4204</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>konstantinshtepa, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>