<table><tr><td style="">drosca created this revision.<br />drosca added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4138" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>There is no difference for normal streams where setVolume and setMute<br />
are two different API calls, but it fixes issue with setting volume to<br />
0 for ext-stream-restore streams (notification sounds) where there is<br />
only one API call to change all stream properties.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Moving volume slider to 0 for Notification sounds in KCM now correctly<br />
sets the volume to 0 and mute it. Functionality with other streams is unchanged.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>mute-eventstream</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4138" rel="noreferrer">https://phabricator.kde.org/D4138</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applet/contents/ui/ListItemBase.qml<br />
src/kcm/package/contents/ui/VolumeSlider.qml</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>drosca, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>