<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129736/">https://git.reviewboard.kde.org/r/129736/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129736/diff/3/?file=488347#file488347line45" style="color: black; font-weight: bold; text-decoration: underline;">holidays/plan2/holiday_pl_pl</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">:: TODO: 6th of January is a public holiday only starting from 2011; how to mark it in this file?</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Please see how I did it for an Italian (new) public holiday, "Festa della Repubblica", see both lines:
https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n27
https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?h=Applications/16.12#n80</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129736/diff/3/?file=488347#file488347line60" style="color: black; font-weight: bold; text-decoration: underline;">holidays/plan2/holiday_pl_pl</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">:: TODO: These are Roman Catholic celebrations. Although this is a dominant religion in Poland, we have quite a few<span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IIRC there is no specific way right now unfortunately. If you say <holidayname> and most people perceive it as that date, it would be fine to leave it as it is. At most you can add a note like "(Roman Catholic Church)" (translated of course)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129736/diff/3/?file=488347#file488347line122" style="color: black; font-weight: bold; text-decoration: underline;">holidays/plan2/holiday_pl_pl</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">101</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">"Równonoc wiosenna" seasonal on 20 march 2005</pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">uhm, are those really required? It should be better to add the calculation of the date in the library. But that can take ages, so this is more a note.</p></pre>
</div>
</div>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On gennaio 1st, 2017, 9:38 a.m. CET, Roman Standzikowski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Roman Standzikowski.</div>
<p style="color: grey;"><i>Updated Gen. 1, 2017, 9:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kholidays
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch contains updated holidays for Poland. This would fix bug https://bugs.kde.org/show_bug.cgi?id=365153.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For general information about polish holidays (especially the ones we do not work in Poland), see:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">see https://en.wikipedia.org/wiki/Public_holidays_in_Poland</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU20150000090</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes:
- [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a public holiday, since 2011 (see https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
- '?ledzik' is not really a religious holiday, this is just the last day of carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no special religious celebrations at this day in Poland
- moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure what is the different between 'civil' and 'cultural' holidays, but it seems no sense to have just the Valentine's Day in cultural and nothing else there
- 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday (see https://en.wikipedia.org/wiki/All_Souls%27_Day, https://pl.wikipedia.org/wiki/Zaduszki)
- 'Wigilia' is also a religious holiday (see https://en.wikipedia.org/wiki/Christmas_Eve, https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
- 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit complicated; this is both Army Day and Assumption of the Blessed Virgin Mary (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the polish law act the Assumption is mentioned, it is now a 'public religious', and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
- 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan tradition; since it is not mentioned in the polish law act, I have moved it to civil (this day is a holiday, because it is also a second day of Easter). I am not 100% sure about this change, any help would be welcome
- 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I couldn't resist :)
- added 'T?usty Czwartek' ('Fat Thursday' - https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no special religious celebrations this day, I have marked it as civil
- added 'Dzie? Górnika' ('Miners Day' - https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional celebration held in mining areas of Poland
- added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every school
- renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
- polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. Andrew's Day'; moved to 29th November, as 30th November is already after the feast
- daylight saving time added (same time is in the whole European Union) - 'Czas letni', 'Czas zimowy'
- added 'Prima Aprilis' ('April Fools' Day')
- added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
- added 'Dzie? Zwyci?stwa' ('Victory Day' - see https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
- added equinoxes and solstices
- added comment about polish school holidays</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>holidays/plan2/holiday_pl_pl <span style="color: grey">(54d56ac)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>