<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3926" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>libdbusmenu-qt had an awful bug in it that meant it would spawn a nested<br />
event loop when updating a menu.</p>

<p>In order to fix StatusNotifierItem I ended up making a fork of the 3<br />
small classes that we needed and applying a fix, whilst we waited for<br />
upstream.</p>

<p>We also were including a complicated library+plugin that handled import<br />
and exporting, just to do importing which is rather pointless.</p>

<p>When appmenu support was restored, we ended up re-linking the original<br />
dbusmenu-qt library. The original still had the same bug, manifesting in<br />
a whole new way of Kate's bookmarks menu automatically closing when you<br />
click on it.</p>

<p>This patch shares the same libdbusmenu-qt lib we have for the SNI<br />
dataengine with the one for appmenu.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Everything compiles after removing the find package for old libdbusmenu-qt <br />
Menu in the Plasma applet works a lot better, and doesn't have the bug of menus randomly closing.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3926" rel="noreferrer">https://phabricator.kde.org/D3926</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
applets/appmenu/lib/appmenuapplet.cpp<br />
applets/appmenu/plugin/CMakeLists.txt<br />
applets/appmenu/plugin/appmenumodel.cpp<br />
appmenu/CMakeLists.txt<br />
appmenu/appmenu.cpp<br />
appmenu/verticalmenu.cpp<br />
dataengines/statusnotifieritem/CMakeLists.txt<br />
dataengines/statusnotifieritem/libdbusmenuqt/README<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.cpp<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.h<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.h<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.cpp<br />
dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.h<br />
dataengines/statusnotifieritem/libdbusmenuqt/utils.cpp<br />
dataengines/statusnotifieritem/libdbusmenuqt/utils_p.h<br />
libdbusmenuqt/CMakeLists.txt<br />
libdbusmenuqt/README<br />
libdbusmenuqt/dbusmenuimporter.cpp<br />
libdbusmenuqt/dbusmenuimporter.h<br />
libdbusmenuqt/dbusmenushortcut_p.cpp<br />
libdbusmenuqt/dbusmenushortcut_p.h<br />
libdbusmenuqt/dbusmenutypes_p.cpp<br />
libdbusmenuqt/dbusmenutypes_p.h<br />
libdbusmenuqt/utils.cpp<br />
libdbusmenuqt/utils_p.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>