<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129731/">https://git.reviewboard.kde.org/r/129731/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Martin Koller.</div>
<div>By Pino Toscano.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look for gperf, and use it to generate the hash-based lookup for the
requests table; this replaces the static generated file in the sources,
adding a build time only dependency on gperf to the man kioslave.
The new FindGperf.cmake module is a local copy of the newly proposed
module for ECM [1], which will need to stay here until the module is
included in ECM, and the build time ECM dependency is risen to the
version containing it.
The output file is now named as header, since it is used a bit like
that, and surely is better than C++ code with a .c extension.
[1] https://phabricator.kde.org/D3830</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine as before, and the gperf output in the build directory matches the removed generated source.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(edc2639e5aef00ef48bab8359bed34633fab26ee)</span></li>
<li>cmake/FindGperf.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>man/CMakeLists.txt <span style="color: grey">(cb4585a289d3f69b8a16429ce87bfce115d1cc27)</span></li>
<li>man/request_gperf.c <span style="color: grey">(aa8bc04333ad869751fad277b8c8e0ac71a00cf8)</span></li>
<li>man/request_hash.cpp <span style="color: grey">(0e9c0ecbdbec1dd03cc7891f0aa8a81eba872b9a)</span></li>
<li>man/tests/CMakeLists.txt <span style="color: grey">(9612b648dec868222e0c160d4839150a7fa2916f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129731/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>