<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129691/">https://git.reviewboard.kde.org/r/129691/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 27th, 2016, 4:54 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129691/diff/1/?file=487931#file487931line682" style="color: black; font-weight: bold; text-decoration: underline;">applets/digital-clock/plugin/timezonesi18n.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">680</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ENTRY_ISO_3166</span><span class="p">(</span><span class="n">CapeVerde</span><span class="p">,</span> <span class="s">"Ca<span class="hl">pe</span> Verde"</span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">682</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ENTRY_ISO_3166</span><span class="p">(</span><span class="n">CapeVerde</span><span class="p">,</span> <span class="s">"Ca<span class="hl">bo</span> Verde"</span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should stay Cape Verde, the English name is used here, not the Portuguese (?) one.</p></pre>
</blockquote>
<p>On December 27th, 2016, 5:30 p.m. CET, <b>Jiri Bohac</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Frankly, I don't understand what all the discussion here is about.
I noticed the list of countries, obviously taken from iso-codes some day in the past, was out of date.
The comment above the hash table clearly says "Make sure the country names match their versions in iso-codes".
So I went and fixed everything to the current version of the ISO standard. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Suddenly, people start disputing the changes with reasoning like:
"This should stay Cape Verde, the English name is used here, not the Portuguese"
"Czech Republic" is correct as well, since it's the official name"
"Congo" is IMHO way too ambiguous</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am no expert on naming countries. There are whole commities doing that at UN and ISO. They decided that
"Czechia", "Congo" and "Cabo Verde" are the correct short names and updated their databases/standards.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would have loved [not] to see such a discussion when populating this hash table from scratch :))</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I find it totally unsystematic to maitain a few records out of sync with iso-codes. Either by using an old version (Cabo Verde) or not using a newly standardized short version. Why would anyone think the snapshot of iso_3116 from ~1 year ago was good and suddenly new ammendment to the standard are controversial?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If someone, who is a better expert on international politics and territory naming than the UN, feels they want to use any subset of my changes, feel free to do that. I totally don't understand any reasoning behind that, though.</p></pre>
</blockquote>
<p>On December 27th, 2016, 5:43 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can't comment on the other changes (In fact, I ACK'ed them, so I explicitely didn't), but when I looked up Cabo Verde, all I could find is the English version, so Cape Verde. If you have a more recent version, I'm all open for it. If you're posting reviews just to have them rubber-stamped by a robot who doesn't actually review and think the changes through, that's not what our code reviews is about.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree that it's a PITA to maintain the list in several places.</p></pre>
</blockquote>
<p>On December 27th, 2016, 6:26 p.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">people start disputing the changes with reasoning like:
"Czech Republic" is correct as well, since it's the official name"</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I never disputed anything, I merely stated that personally, as a Czech, I prefer "Czech Republic" over "Czechia" and even explicitly said that my comment is not to block your change. Please don't take my words out of context.</p></pre>
</blockquote>
<p>On December 27th, 2016, 6:49 p.m. CET, <b>Jiri Bohac</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A robot would not give useful reviews like
"you updated the hashtable but forgot to update this NumCountries constant..."
"the string needs to be identical to YetAnotherCountryList in another repository..."
"changing this now will not allow the translators to update the translations, postpone..."
or "you made a typo here, forgot to copy the first letter of this country name"
So I greatly appreciate your review process.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't understand why <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">people</em> argue with <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">updating string constants</em> to the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">current standard</em>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That said, I don't care about Cabo Verde. If that is a blocker for the patch, I'll happily let someone else fight for making its name up to date. I uploaded a "fixed" patch without the Cabo Verde change.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">isoquery -v
isoquery 3.2.1
Copyright © 2007-2016 Dr. Tobias Quathamer</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
martin@martin-desktop: ~ $ isoquery -c | grep Verde
CV CPV 132 Cabo Verde
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's all calm down a little bit, please. @sebas: where did you check about Cape Verde?</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On December 27th, 2016, 6:48 p.m. CET, Jiri Bohac wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Jiri Bohac.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2016, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update the list of country names to the current names in iso-codes
(as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not enough:
country names are hardcoded in many places and they need to be fixed separately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonesi18n.cpp <span style="color: grey">(10650f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129691/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>