<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3813" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hi, ,Thanks for the patch !</p>
<p>Do you have an example application for which this fixes the issue ? <br />
I'm a bit worried about the possible regressions that your change introduced, so I would like to understand better what happens here ...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3813#inline-15126" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezestyle.cpp:3067</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> // no focus indicator on buttons, since it is rendered elsewhere
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> if ( <span class="bright">widget && qobject_cast< const QAbstractButton</span>*>( widget ) )
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> // no focus indicator on buttons<span class="bright"> / scrollbars</span>, since it is rendered elsewhere
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> if ( <span class="bright">qobject_cast< const QAbstractButton*>( widget ) || qobject_cast< const QScrollBar</span>*>( widget ) )
</div><div style="padding: 0 8px; margin: 0 4px; "> return true;
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You sure this is actually needed ? The primitive is supposed to do an horizontal line below the passed rect. Never seen that happened for scrollbars. Does it really ? (without the patch)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3813" rel="noreferrer">https://phabricator.kde.org/D3813</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>drosca, Plasma, hpereiradacosta<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>