<table><tr><td style="">ivan updated the summary for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-nvymz5emiplfma3/" rel="noreferrer">(Show Details)</a><br />ivan updated the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-lcxz6d7odou2h6m/" rel="noreferrer">(Show Details)</a><br />ivan removed R119 Plasma Desktop as the repository for this revision.<br />ivan updated this revision to Diff 9360.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3805" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>EDIT DETAILS</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>The favourites are based on KAStats (current master). <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">The backend part seems to work</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.<br />
<br />
This change covers applications and contacts</span>, <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">the UI needs polishing</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">other favourites are still based on the old model (now named SimpleFavoritesModel)</span>.<br />
<br />
<span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">TODOs:</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">{F1028047}</span><br />
<br />
<span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">- Move the activity assignment actions into a sub-menu (need to figure out how)<br />
- Polish the UI to have all actions disabled if 'all activities' item is selected</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">This patch requires KF 5.30. This probably means it will have to wait for Plasma 5.10 since 5.9 will not depend on 5.30.<br />
<br />
TODOs:<br />
</span><br />
- Implement adding a favourite to a specific location (for the dashboard)<br />
</div></div></div><br /><div><strong>EDIT DETAILS</strong><div><div style="white-space: pre-wrap; color: #74777D;">So far tested in Kicker.<span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);"><br />
<br />
Needs more extensible testing.</span></div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3805?vs=9348&id=9360" rel="noreferrer">https://phabricator.kde.org/D3805?vs=9348&id=9360</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3805" rel="noreferrer">https://phabricator.kde.org/D3805</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/kicker/CMakeLists.txt<br />
applets/kicker/package/contents/code/tools.js<br />
applets/kicker/package/contents/ui/ActionMenu.qml<br />
applets/kicker/plugin/computermodel.cpp<br />
applets/kicker/plugin/computermodel.h<br />
applets/kicker/plugin/favoritesmodel.cpp<br />
applets/kicker/plugin/favoritesmodel.h<br />
applets/kicker/plugin/kastatsfavoritesmodel.cpp<br />
applets/kicker/plugin/kastatsfavoritesmodel.h<br />
applets/kicker/plugin/kickerplugin.cpp<br />
applets/kicker/plugin/recentusagemodel.cpp<br />
applets/kicker/plugin/rootmodel.cpp<br />
applets/kicker/plugin/rootmodel.h<br />
applets/kicker/plugin/simplefavoritesmodel.cpp<br />
applets/kicker/plugin/simplefavoritesmodel.h<br />
applets/kicker/plugin/systemmodel.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>ivan, hein, mart<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>