<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128038/">https://git.reviewboard.kde.org/r/128038/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Декември 21st, 2016, 2:58 преди обяд EET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128038/diff/6/?file=487005#file487005line37" style="color: black; font-weight: bold; text-decoration: underline;">applets/taskmanager/package/contents/ui/GroupDialog.qml</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">property</span> <span class="kr">int</span> <span class="k">preferredWidth:</span> <span class="nx">Screen</span><span class="p">.</span><span class="nx">width</span> <span class="o">/</span> <span class="p">(</span><span class="mi">3</span> <span class="o">*</span> <span class="nx">Screen</span><span class="p">.</span><span class="nx">devicePixelRatio</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">note we've moved to phabricator for review requests, which is why this got ignored.
Though this was still unexcusable on our side for not commenting in 6 months.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why are you multiplying anything by devicePixelRatio in this ?
The logic is saying "don't be more than a 3rd of the screen width". </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, to match the comment in the TODO this should be Screen.desktopAvailableWidth</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About me, 640 is exactly 1920/3 in TODO. If you think this should be
property int preferredWidth: Screen.desktopAvailableWidth / (3 * Screen.devicePixelRatio)
property int preferredHeight: Screen.desktopAvailableHeight / (2 * Screen.devicePixelRatio)
i will committed.</p></pre>
<br />
<p>- Anthony</p>
<br />
<p>On Декември 16th, 2016, 6:38 преди обяд EET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike Hein.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Дек. 16, 2016, 6:38 преди обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Enable highlighted window, tooltips and grouping</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Open group item tasl by clicking left mouse button</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Move mouse cursor over item in group</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before:
1. Items are samll and tough readable
2. Items aren't visible cause a highligthWindow effect
3. Clicking on tooltip close button case highlightWindow effect to not stop</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After:
1. Items are proof readable
2. Items are visible
3. HighlightWdindow effect is stopped</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshot with expected behavior by clicking left button on group item.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/GroupDialog.qml <span style="color: grey">(829fcf0)</span></li>
<li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: grey">(0a59d53)</span></li>
<li>applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml <span style="color: grey">(e3551df)</span></li>
<li>applets/taskmanager/package/contents/ui/main.qml <span style="color: grey">(e53b194)</span></li>
<li>applets/taskmanager/plugin/backend.h <span style="color: grey">(a3788b0)</span></li>
<li>applets/taskmanager/plugin/backend.cpp <span style="color: grey">(4ef5b88)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128038/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/35dd438c-fae2-4daa-ba30-09f70ea3b920__Screenshot_20161203_210914.png">Vertical panel</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/fe7c9cab-bb2a-4d17-85de-1934c81a33dc__Screenshot_20161203_211120.png">Horizontal panel</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>