<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3655" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3655#inline-14525" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appentry.h:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">AppGroupEntry</span><span class="p">(</span><span class="n">AppsModel</span> <span style="color: #aa2211">*</span><span class="n">parentModel</span><span class="p">,</span> <span class="n">KServiceGroup</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">group</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">bool</span> <span class="n">flat</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">sorted</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">separators</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">appNameFormat</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">bool</span> <span class="bright"></span><span class="n"><span class="bright">paginate</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">pageSize</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n">flat</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">sorted</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">separators</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">appNameFormat</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">a constructor with a list of bool parameters doesn't look particularly good, but as i see was already like that before adding the paginate option, so is probably a bit late.. I would probably have seen bettea couple of different subclasses for different entries style? (same for the model)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3655#inline-14526" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appsmodel.h:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #a0a000">public</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="n">explicit</span> <span class="n">AppsModel</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">entryPath</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(),</span> <span style="color: #aa4000">bool</span> <span class="bright"></span><span class="n"><span class="bright">flat</span></span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">sorted</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">separators</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QObject</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">parent</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">explicit</span> <span class="n">AppsModel</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">entryPath</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(),</span> <span style="color: #aa4000">bool</span> <span class="bright"></span><span class="n"><span class="bright">paginate</span></span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">pageSize</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">24</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">bool</span> <span class="n">flat</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">sorted</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">separators</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">,</span> <span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">are all those parameters really needed right in the ctor?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3655" rel="noreferrer">https://phabricator.kde.org/D3655</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma, mart<br /><strong>Cc: </strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>