<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3667" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>LGTM overall</p>

<p>"Prototype of redesigned taskbar" made me curious ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3667#inline-14556" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">playercontainer.cpp:123</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">int</span> <span class="n">secondaryInstancePid</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">int</span> <span class="n">lastPoint</span> <span style="color: #aa2211">=</span> <span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">lastIndexOf</span><span class="p">(</span><span style="color: #766510">"."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QString</span> <span class="n">end</span> <span style="color: #aa2211">=</span> <span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">right</span><span class="p">(</span><span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span class="n">lastPoint</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QLatin1Char?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3667#inline-14555" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">playercontainer.cpp:124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">int</span> <span class="n">lastPoint</span> <span style="color: #aa2211">=</span> <span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">lastIndexOf</span><span class="p">(</span><span style="color: #766510">"."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QString</span> <span class="n">end</span> <span style="color: #aa2211">=</span> <span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">right</span><span class="p">(</span><span class="n">m_dbusAddress</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span class="n">lastPoint</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">pre</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"instance"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you use rightRef and the like, if possible?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3667#inline-14557" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">playercontainer.cpp:128</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">end</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="n">pre</span><span class="p">.</span><span class="n">length</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">bool</span> <span class="n">convertSuccess</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">end</span><span class="p">.</span><span class="n">toInt</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">convertSuccess</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">bool ok;</pre></div>

<p style="padding: 0; margin: 8px;">is sufficient in that context imho</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3667" rel="noreferrer">https://phabricator.kde.org/D3667</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>subdiff, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>