<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3495" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3495#inline-14395" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_qpainter_test.cpp:199</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">using</span> <span style="color: #aa4000">namespace</span> <span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Client</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">setupWaylandConnection</span><span class="p">(</span><span class="n">s_socketName</span><span class="p">,</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">AdditionalWaylandInterface</span><span style="color: #aa2211">::</span><span class="n">Seat</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">waitForWaylandPointer</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you don't need to do the Test::setupWaylandConnection in the test, that's part of the init()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3495#inline-14396" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_qpainter_test.cpp:202-203</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">Surface</span><span style="color: #aa2211">></span> <span class="n">s</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">createSurface</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">QObject</span><span style="color: #aa2211">></span> <span class="n">ss</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">createShellSurface</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">ShellSurfaceType</span><span style="color: #aa2211">::</span><span class="n">WlShell</span><span class="p">,</span> <span class="n">s</span><span class="p">.</span><span class="n">data</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">Pointer</span><span style="color: #aa2211">></span> <span class="n">p</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">waylandSeat</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">createPointer</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the idea of the Test::createShellSurface variant returning a QObject is to have a test_data() with the two supported modes, so that we test both WlShell and XdgShellUnstableV5. You can compare with other tests.</p>

<p style="padding: 0; margin: 8px;">If you want to only test WlShell there is a simplified setup method returning a ShellSurface instead of QObject.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3495#inline-14397" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_qpainter_test.cpp:230-231</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">referenceImage</span><span class="p">.</span><span class="n">save</span><span class="p">(</span><span style="color: #766510">"/tmp/expected.png"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">scene</span><span style="color: #aa2211">-></span><span class="n">backend</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">buffer</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">save</span><span class="p">(</span><span style="color: #766510">"/tmp/actual.png"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">referenceImage</span><span class="p">,</span> <span style="color: #aa2211">*</span><span class="n">scene</span><span style="color: #aa2211">-></span><span class="n">backend</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">buffer</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why are you saving to the tmp directory?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3495" rel="noreferrer">https://phabricator.kde.org/D3495</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>