<table><tr><td style="">mart requested changes to this revision.<br />mart added a reviewer: mart.<br />mart added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3630" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3630#inline-14390" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DigitalClock.qml:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// if the date/timezone cannot be fit with the smallest font to its designated space</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">bool</span> <span style="color: #aa4000">tooSmall:</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">formFactor</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">Horizontal</span> <span style="color: #aa2211">&&</span> <span style="color: #304a96">Math</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">round</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">height<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">5</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>)</span> <span style="color: #aa2211"><=</span> <span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">smallestFont</span><span class="p">.</span><span style="color: #004012">p<span class="bright">ixel</span>Size</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">bool</span> <span style="color: #aa4000">tooSmall:</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">formFactor</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">Horizontal</span> <span style="color: #aa2211">&&</span> <span style="color: #304a96">Math</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">floor</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0.4</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #004012">main</span><span class="p">.</span><span style="color: #004012">height</span><span class="p">)</span> <span style="color: #aa2211"><=</span> <span style="color: #004012">theme</span><span class="p">.</span><span style="color: #004012">smallestFont</span><span class="p">.</span><span style="color: #004012">p<span class="bright">oint</span>Size</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">here you are comparing points and pixels</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3630" rel="noreferrer">https://phabricator.kde.org/D3630</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>subdiff, Plasma, mart<br /><strong>Cc: </strong>mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>