<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3606" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Note that actions won't work, we'd always be replying on the session bus. (this is solvable)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3606#inline-14356" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notificationsengine.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #74777d">// TODO only do that when plasmashellrc has [Notifications] BroadcastAllowed or sth like that</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span class="n">systemBus</span><span class="p">().</span><span class="n">connect</span><span class="p">({},</span> <span class="p">{},</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"org.kde.plasmashell.broadcastNotification"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Notify"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">onBroadcastNotification</span><span class="p">(</span><span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span><span class="n">QVariant</span><span style="color: #aa2211">></span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd get rid of the plasmashell in the iface name.<br />
Otherwise you're tying an implementation detail into an API.</p>
<p style="padding: 0; margin: 8px;">Also for whatever reason convention is to be UpperCamelCase (i.e BroadcastNotification not broadcastNotification)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3606#inline-14301" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notificationsengine.cpp:426</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">auto</span> <span class="n">userId</span> <span style="color: #aa2211">=</span> <span class="n">properties</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"uid"</span><span class="p">)).</span><span class="n">toULongLong</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">userId</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">userIds</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">userId</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is it intended that you can't send a message to root?</p>
<p style="padding: 0; margin: 8px;">otherwise toULongLong(&rc );<br />
if (rc) {..}</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3606" rel="noreferrer">https://phabricator.kde.org/D3606</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>