<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3603" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Nifty. That I haven't thought of that kind of placement before. I always wanted some crappy overlay like we had before.</p>
<p>Can you please check again with opacity mask instead of just overlaying a Rectangle. Also, what's up with the Canvas thing?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3603#inline-14244" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.xml:11</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><label></span>If true, the battery will display a little charge percentage label inside.<span style="color: #00702a"></label></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"><default></span>false<span style="color: #00702a"></default></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #00702a"></entry></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this could even be the default?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3603#inline-14241" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CompactRepresentation.qml:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">Rectangle</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you instead try an OpacityMask / ShaderEffect thing like I did in task manager for the badge so we actually cut out a piece of the icon instead of just overlaying an opaque rectangle?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3603#inline-14240" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CompactRepresentation.qml:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: batteryLabel</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">width</span>:</span> <span style="color: #004012">parent<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">width</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">height:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000">paintedHeight<span class="bright"> :</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">anchors.centerIn</span>:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">height:</span> <span style="color: #004012">paintedHeight</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">for fonts avoid vertically anchoring it, use verticalAlignment instead to ensure descenders are properly taken into account</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3603#inline-14242" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CompactRepresentationCircle.qml:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">bool</span> <span style="color: #aa4000">hasBattery:</span> <span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">singleBattery</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">view.hasBattery :</span> <span style="color: #004012">model</span><span class="p">[</span><span style="color: #766510">"Plugged in"</span><span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">percent:</span> <span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">singleBattery</span> <span style="color: #aa2211">?</span> <span style="color: #004012">pmSource</span><span class="p">.</span><span style="color: #004012">data</span><span class="p">[</span><span style="color: #766510">"Battery"</span><span class="p">][</span><span style="color: #766510">"Percent"</span><span class="p">]</span> <span style="color: #aa2211">:</span> <span style="color: #004012">model</span><span class="p">[</span><span style="color: #766510">"Percent"</span><span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">percent:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">72</span></span><span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>view.singleBattery ? pmSource.data["Battery"]["Percent"] : model["Percent"]</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">bool</span> <span style="color: #aa4000">pluggedIn:</span> <span style="color: #004012">pmSource</span><span class="p">.</span><span style="color: #004012">data</span><span class="p">[</span><span style="color: #766510">"AC Adapter"</span><span class="p">]</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">pmSource</span><span class="p">.</span><span style="color: #004012">data</span><span class="p">[</span><span style="color: #766510">"AC Adapter"</span><span class="p">][</span><span style="color: #766510">"Plugged in"</span><span class="p">]</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">singleBattery</span> <span style="color: #aa2211">||</span> <span style="color: #004012">model</span><span class="p">[</span><span style="color: #766510">"Is Power Supply"</span><span class="p">])</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">;)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3603" rel="noreferrer">https://phabricator.kde.org/D3603</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>