<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129615/">https://git.reviewboard.kde.org/r/129615/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QtCurve defines a certain number of specific XCB client messages that are sent under certain conditions. As far as I can tell these are destined to GTk2 applications using the QtCurve theme, but they are sent regardless of the nature of the client (so also to Qt-based applications).
Qt4 doesn't seem to mind, but Qt5 tends to print a warning whenever an unknown/unsupported client message is received, which is not very elegant.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been using the attached patch for a while now that suppresses these error messages by not sending the XCB client messages that Qt5 complained to me about. Curiously this never happened for messages related to menu- and statusbar toggling.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't notice any regressions, but I have only tested this on KDE desktops. I'm CC'ing the Plasma group in hope someone there may have suggestions for a more elegant fix.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On Kubuntu 14.04 under Plasma4 with KF5 applications installed in /opt/local .</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/utils/x11utils.cpp <span style="color: grey">(40339e3)</span></li>
<li>qt4/kwin/qtcurveclient.cpp <span style="color: grey">(80855cf)</span></li>
<li>qt5/kwin/qtcurveclient.cpp <span style="color: grey">(d784bd4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129615/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>