<table><tr><td style="">graesslin created this revision.<br />graesslin added reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3571" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>By changing all kcfg to have arg="true" we can pass in the same<br />
KSharedConfigPtr into all effects. This allows to have fake config in<br />
the tests and in the planned effect demo mode.</p>

<p>Also it means that we don't have to hardcode the name kwinrc into the<br />
files. In the configs - where we cannot access the effectshandler - we<br />
use the define KWIN_CONFIG which gets generated based on the compile<br />
time arguments.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>effects-singleton-arg</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3571" rel="noreferrer">https://phabricator.kde.org/D3571</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/integration/effects/slidingpopups_test.cpp<br />
autotests/mock_effectshandler.cpp<br />
autotests/mock_effectshandler.h<br />
effects.cpp<br />
effects.h<br />
effects/blur/blur.cpp<br />
effects/blur/blur.kcfg<br />
effects/blur/blur_config.cpp<br />
effects/coverswitch/coverswitch.cpp<br />
effects/coverswitch/coverswitch.kcfg<br />
effects/coverswitch/coverswitch_config.cpp<br />
effects/cube/cube.cpp<br />
effects/cube/cube.kcfg<br />
effects/cube/cube_config.cpp<br />
effects/cube/cubeslide.cpp<br />
effects/cube/cubeslide.kcfg<br />
effects/cube/cubeslide_config.cpp<br />
effects/desktopgrid/desktopgrid.cpp<br />
effects/desktopgrid/desktopgrid.kcfg<br />
effects/desktopgrid/desktopgrid_config.cpp<br />
effects/diminactive/diminactive.cpp<br />
effects/diminactive/diminactive.kcfg<br />
effects/diminactive/diminactive_config.cpp<br />
effects/fallapart/fallapart.cpp<br />
effects/fallapart/fallapart.kcfg<br />
effects/flipswitch/flipswitch.cpp<br />
effects/flipswitch/flipswitch.kcfg<br />
effects/flipswitch/flipswitch_config.cpp<br />
effects/glide/glide.cpp<br />
effects/glide/glide.kcfg<br />
effects/glide/glide_config.cpp<br />
effects/kscreen/kscreen.cpp<br />
effects/kscreen/kscreen.kcfg<br />
effects/lookingglass/lookingglass.cpp<br />
effects/lookingglass/lookingglass.kcfg<br />
effects/lookingglass/lookingglass_config.cpp<br />
effects/magiclamp/magiclamp.cpp<br />
effects/magiclamp/magiclamp.kcfg<br />
effects/magiclamp/magiclamp_config.cpp<br />
effects/magnifier/magnifier.cpp<br />
effects/magnifier/magnifier.kcfg<br />
effects/magnifier/magnifier_config.cpp<br />
effects/mouseclick/mouseclick.cpp<br />
effects/mouseclick/mouseclick.kcfg<br />
effects/mouseclick/mouseclick_config.cpp<br />
effects/mousemark/mousemark.cpp<br />
effects/mousemark/mousemark.kcfg<br />
effects/mousemark/mousemark_config.cpp<br />
effects/presentwindows/presentwindows.cpp<br />
effects/presentwindows/presentwindows.kcfg<br />
effects/presentwindows/presentwindows_config.cpp<br />
effects/resize/resize.cpp<br />
effects/resize/resize.kcfg<br />
effects/resize/resize_config.cpp<br />
effects/sheet/sheet.cpp<br />
effects/sheet/sheet.kcfg<br />
effects/showfps/showfps.cpp<br />
effects/showfps/showfps.kcfg<br />
effects/showfps/showfps_config.cpp<br />
effects/slidingpopups/slidingpopups.cpp<br />
effects/slidingpopups/slidingpopups.kcfg<br />
effects/thumbnailaside/thumbnailaside.cpp<br />
effects/thumbnailaside/thumbnailaside.kcfg<br />
effects/thumbnailaside/thumbnailaside_config.cpp<br />
effects/trackmouse/trackmouse.cpp<br />
effects/trackmouse/trackmouse.kcfg<br />
effects/trackmouse/trackmouse_config.cpp<br />
effects/windowgeometry/windowgeometry.cpp<br />
effects/windowgeometry/windowgeometry.kcfg<br />
effects/windowgeometry/windowgeometry_config.cpp<br />
effects/wobblywindows/wobblywindows.cpp<br />
effects/wobblywindows/wobblywindows.kcfg<br />
effects/wobblywindows/wobblywindows_config.cpp<br />
effects/zoom/zoom.cpp<br />
effects/zoom/zoom.kcfg<br />
effects/zoom/zoom_config.cpp<br />
libkwineffects/CMakeLists.txt<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas<br /></div>