<table><tr><td style="">broulik updated the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-mg5nqslfcamlscn/" rel="noreferrer">(Show Details)</a><br />broulik updated this revision to Diff 8662.<br />broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3539" rel="noreferrer">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Put thumbnail strip behind a Loader</li>
<li class="remarkup-list-item">Make clicking the thumbnails actually work (horrible hack because of the MouseEventListener we have in the popup)</li>
<li class="remarkup-list-item">Make thumbnails in the notification history work</li>
</ul></div></div><br /><div><strong>EDIT DETAILS</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>{F555700}<br />
<br />
<span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">Clicking the thumbnails currently doesn't work because the MEL eats the click away. Also, r</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">R</span>ight-click does nothing - would be neat to have the regular KIO file context menu there.<br />
It <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">also </span>doesn't properly work with grouping, ie. when two notifications are grouped together, the thumbnail shown is the one from the last notification.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3539?vs=8625&id=8662" rel="noreferrer">https://phabricator.kde.org/D3539?vs=8625&id=8662</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3539" rel="noreferrer">https://phabricator.kde.org/D3539</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/notifications/package/contents/ui/NotificationDelegate.qml<br />
applets/notifications/package/contents/ui/NotificationItem.qml<br />
applets/notifications/package/contents/ui/NotificationPopup.qml<br />
applets/notifications/package/contents/ui/ThumbnailStrip.qml<br />
applets/notifications/plugin/CMakeLists.txt<br />
applets/notifications/plugin/notificationshelperplugin.cpp<br />
applets/notifications/plugin/thumbnailer.cpp<br />
applets/notifications/plugin/thumbnailer.h<br />
dataengines/notifications/notificationsengine.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, Plasma: Design<br /><strong>Cc: </strong>mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>