<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3479" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3479#inline-13619" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">connection.h:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">Q_CLASSINFO</span><span class="p">(</span><span style="color: #766510">"D-Bus Interface"</span><span class="p">,</span> <span style="color: #766510">"org.kde.KWin.InputDeviceManager"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QStringList</span> <span class="n">devicesSysNames</span> <span class="n">READ</span> <span class="n">devicesSysNames</span> <span class="n">CONSTANT</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">public</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This isn't constant.<br />
Connection::processEvents() will update m_devices</p>

<p style="padding: 0; margin: 8px;">Rather than add a notify on here, common practice is generally to have a :</p>

<p style="padding: 0; margin: 8px;">q_signals:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">deviceAdded(QDBusObjectPath pathOfNewlyAddedObject)
deviceRemoved(QDBusObjectPath oldPath)   or some UUID</pre></div>

<p style="padding: 0; margin: 8px;">(remember to export the signals as well if you add them)</p>

<p style="padding: 0; margin: 8px;">that way the KCM can avoid reparsing the list and work out what's changed.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3479" rel="noreferrer">https://phabricator.kde.org/D3479</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>subdiff, KWin, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, kwin, KWin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>