<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3451" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3451#inline-13546" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">discretegpu_helper_actions.actions:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">Name=KDE
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">Name[ar]=كدي
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">Name[ast]=KDE
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can drop all those localized ones, this will be (should be?) taken care of by scripty</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3451#inline-13544" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">discretegpuhelper.h:32</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #a0a000">public</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">DiscreteGpuHelper</span><span class="p">(</span><span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">explicit</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3451#inline-13545" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilbackendinterface.cpp:33</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Private</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">acAdapterState</span><span class="p">(</span><span class="n">UnknownAcAdapterState</span><span class="p">),</span> <span class="n">batteryState</span><span class="p">(</span><span class="n">NoBatteryState</span><span class="p">),</span> <span class="n">batteryRemainingTime</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span class="n">isReady</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isError</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isLidClosed</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isLidPresent</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span> <span class="p">{}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="bright"></span><span class="n"><span class="bright">hasDualGpu</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #304a96"><span class="bright">false</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n">isReady</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isError</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isLidClosed</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">),</span> <span class="n">isLidPresent</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">)</span> <span class="p">{}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa2211">~</span><span class="n">Private</span><span class="p">()</span> <span class="p">{}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why do we have it both in Core and the backendinterface?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPOWERDEVIL Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3451" rel="noreferrer">https://phabricator.kde.org/D3451</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>jgrulich, broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>