<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128912/">https://git.reviewboard.kde.org/r/128912/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I understand it correctly, the review include two separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation).</p></pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On November 11th, 2016, 10:31 a.m. CET, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Plasma.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2016, 10:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not included in build so far, the docbooks are imported as they were splitted</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5,
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime master</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/CMakeLists.txt <span style="color: grey">(350bce3)</span></li>
<li>docs/kcontrol5/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/cache/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/cache/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/cookies/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/cookies/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/netpref/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/netpref/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/proxy/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/proxy/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/smb/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/smb/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/trash/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/trash/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/useragent/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/useragent/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/webshortcuts/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kcontrol5/webshortcuts/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/trash/kcmtrash.desktop <span style="color: grey">(c8ff4ac)</span></li>
<li>src/kcms/kio/cache.desktop <span style="color: grey">(f0bd261)</span></li>
<li>src/kcms/kio/cookies.desktop <span style="color: grey">(f91b5cd)</span></li>
<li>src/kcms/kio/netpref.desktop <span style="color: grey">(963ef3f)</span></li>
<li>src/kcms/kio/proxy.desktop <span style="color: grey">(c11451d)</span></li>
<li>src/kcms/kio/smb.desktop <span style="color: grey">(c323614)</span></li>
<li>src/kcms/kio/useragent.desktop <span style="color: grey">(856e9cc)</span></li>
<li>src/kcms/webshortcuts/webshortcuts.desktop <span style="color: grey">(24fbb2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128912/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output">git-log-doc-kcontrol.output</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>