<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128914/">https://git.reviewboard.kde.org/r/128914/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2016, 1:51 nachm. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I understand it correctly, the review include two separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes thes are two separate changes, the import + update in one RR, see kde-cli-tools-log-doc.txt
That way we have less trouble with scripty</p></pre>
<br />
<p>- Burkhard</p>
<br />
<p>On November 11th, 2016, 9:02 vorm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Documentation, Localization and Translation (l10n) and Plasma.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2016, 9:02 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">doc/kcontrol/filetypes/ splitted from kde-runtime master using https://github.com/ajdruff/git-splits</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not included in build so far, the docbook ismported as it was splitted</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To be done next:
adapt CMakeLists.txt, change dtd to kf5,
reapply one update done in plasma-desktop
make co-installable, see https://git.reviewboard.kde.org/r/128912/
remove this imported kcontrol docbook from plasma-desktop
adapt scripty to these changes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log in kde-runtime master</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/CMakeLists.txt <span style="color: grey">(6987c14)</span></li>
<li>doc/kcontrol5/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol5/filetypes/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol5/filetypes/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>keditfiletype/filetypes.desktop <span style="color: grey">(76f11cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128914/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output">git-log-doc-kcontrol-kio-cli-tools.output</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>