<table><tr><td style="">graesslin created this revision.<br />graesslin added reviewers: KWin, Plasma.<br />Restricted Application added a project: KWin.<br />Restricted Application added subscribers: kwin, plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3288" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>If a graphics reset happens during compositing startup it is possible<br />
that the next try to start compositing will run into the same graphics<br />
reset. In that case KWin would be in an endless restart compositor loop.</p>
<p>This change makes use of the frames to test for safety. If a graphics<br />
reset happens while there are still frames to test we consider the<br />
OpenGL context broken and don't re-enable compositing.</p>
<p>It is not clear whether the number of frames to test is sufficient. In<br />
the bug report we have for the problem, it seems to be during effect<br />
loading. After each loaded effect a frame could be rendered, so maybe<br />
the three frames to test by default are not sufficient.</p>
<p>In master we should also show a notification why compositing got<br />
disabled.</p>
<p>CCBUG: 372145</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>safety-check-graphics-reset-5.8</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3288" rel="noreferrer">https://phabricator.kde.org/D3288</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>composite.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma<br /><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas<br /></div>