<table><tr><td style="">graesslin created this revision.<br />graesslin added reviewers: KWin, Plasma on Wayland.<br />Restricted Application added subscribers: kwin, plasma-devel.<br />Restricted Application added projects: Plasma on Wayland, KWin.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3296" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The glide effect tried to not animate any window the SlidingPopups<br />
effect animates. But it detected that in a very crude way. It announced<br />
the KDE_SLIDE atom and checked for windows having that property set.</p>
<p>This has a few disadvantages:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">KWindowEffects::isEffectAvailable gets confused as an effect announces support for SlidingPopups which doesn't provide SlidingPopups</li>
<li class="remarkup-list-item">The approach can only work for X11 windows</li>
<li class="remarkup-list-item">The approach causes X11 usage in the ctor</li>
</ul>
<p>With this change the GlideEffect implements a slot for<br />
EffectsHandler::windowDataChanged to detect that the SlidingPopupsEffect<br />
grabbed the window. The X11 atom interaction is removed.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>glide-no-atom</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3296" rel="noreferrer">https://phabricator.kde.org/D3296</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>effects/glide/glide.cpp<br />
effects/glide/glide.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland<br /><strong>Cc: </strong>plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas<br /></div>