<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3262" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3262#inline-12851" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">hein</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xwindowtasksmodel.cpp:490-499</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">In KWin we also ensure that the desktopFile ends with .desktop prior to passing to KDesktopFile</p></blockquote>
<p style="padding: 0; margin: 8px;">This shouldn't be necessary. "Passing to KDesktopFile" in this code's case is calling KDesktopFile::isDesktopFile, which is documented to do the following:</p>
<p style="padding: 0; margin: 8px;">"The check is performed looking at the file extension (the file is not opened). Currently, the only valid extension is ".desktop". "</p>
<p style="padding: 0; margin: 8px;">I.e. checking for the extension isn't necessary, that's what isDesktopFile() is doing. Basically, we try to find a KService first, and if that fails we check if it's a .desktop file and whether it exists, then use it.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">exactly. So if you get a name which does not have the .desktop file extension it won't be used.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3262" rel="noreferrer">https://phabricator.kde.org/D3262</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma, graesslin<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>