<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3159" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12887" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">x11windowed_backend.cpp:201-205</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">pointerMotion</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QPointF</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">event</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">root_x</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">xPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">internalPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"> </span><span class="n"><span class="bright">event</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">root_y</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">xPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">y</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">internalPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">y</span></span><span class="bright"></span><span class="p"><span class="bright">()),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//generally we don't need to normalise input to the output scale; however because we're getting input</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #74777d"><span class="bright">//from a host window that doesn't understand scaling, we need to apply it ourselves so the cursor matches</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">pointerMotion</span><span class="p">(</span><span class="n">QPointF</span><span class="p">((</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_x</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">x</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">it</span><span style="color: #aa2211">-></span><span class="n">scale</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_y</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">y</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">it</span><span style="color: #aa2211">-></span><span class="n">scale</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">time</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QPointF supports operator/, so that should be possible to simplify a bit.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12888" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">x11windowed_backend.cpp:234-235</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="n">pointerMotion</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_x</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_y</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">pointerMotion</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(<span class="bright">(</span></span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_x</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">x</span><span class="p">()<span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">scale</span></span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_y</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()<span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">scale</span></span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">time</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12889" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">x11windowed_backend.cpp:370-371</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span class="bright"> </span><span class="n"><span class="bright">pointerMotion</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QPointF</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">event</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">root_x</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">xPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">internalPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"> </span><span class="n"><span class="bright">event</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">root_y</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">xPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">y</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">internalPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">y</span></span><span class="bright"></span><span class="p"><span class="bright">())</span>,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">pointerMotion</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QPointF</span></span><span class="bright"></span><span class="p"><span class="bright">((</span></span><span class="bright"></span><span class="n"><span class="bright">event</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">root_x</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">xPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span class="n"><span class="bright">internalPosition</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">x</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span class="n"><span class="bright">it</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">scale</span></span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">root_y</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">xPosition</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span style="color: #aa2211">*</span><span class="n">it</span><span class="p">).</span><span class="n">internalPosition</span><span class="p">.</span><span class="n">y</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">it</span><span style="color: #aa2211">-></span><span class="n">scale</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">time</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">and here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12894" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_qpainter.cpp:311-313</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span class="bright"></span><span class="n"><span class="bright">src</span></span> <span style="color: #aa2211">=</span> <span class="n">QRect</span><span class="p">(</span><span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">cli<span class="bright">entPos</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">toplevel</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clientCont</span>entPos</span><span class="p">(),</span> <span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">clientSize</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">painter</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">drawImage</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">toplevel</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clientPos</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">pixmap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">image</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">src</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">const</span> <span class="n">QRect</span> <span class="bright"></span><span class="n"><span class="bright">target</span></span> <span style="color: #aa2211">=</span> <span class="n">QRect</span><span class="p">(</span><span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">clientPos</span><span class="p">(),</span> <span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">clientSize</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QRect</span></span><span class="bright"> </span><span class="n"><span class="bright">src</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QRect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">toplevel</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clientPos</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">toplevel</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">clientContentPos</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">pixmap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">image</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">painter</span><span style="color: #aa2211">-></span><span class="n">drawImage</span><span class="p">(</span><span class="n">target</span><span class="p">,</span> <span class="n">pixmap</span><span style="color: #aa2211">-></span><span class="n">image</span><span class="p">(),</span> <span class="n">src</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't understand how the scaling comes in here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12893" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_qpainter.cpp:321</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">paintSubSurface</span><span class="p">(</span><span class="n">painter</span><span class="p">,</span> <span class="n">toplevel</span><span style="color: #aa2211">-></span><span class="n">clientPos</span><span class="p">(),</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">QPainterWindowPixmap</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">pixmap</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">paintSubSurface probably also needs the adjustment</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3159#inline-12891" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">shell_client.cpp:392</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">markAsMapped</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="n">m_clientSize</span> <span style="color: #aa2211">=</span> <span class="n">fbo</span><span style="color: #aa2211">-></span><span class="n">size</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">doSetGeometry</span><span class="p">(</span><span class="n">QRect</span><span class="p">(</span><span class="n">geom</span><span class="p">.</span><span class="n">topLeft</span><span class="p">(),</span> <span class="n">m_clientSize</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">removing that line will break internal windows such as Alt+Tab, etc. etc on SceneOpenGL</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>scaling</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3159" rel="noreferrer">https://phabricator.kde.org/D3159</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, graesslin, Plasma<br /><strong>Cc: </strong>broulik, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>