<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3200" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12502" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DashboardRepresentation.qml:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">function</span> <span style="color: #004012">updateWidgetExplorer</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">tabBar</span><span class="p">.</span><span style="color: #004012">activeTab</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span> <span style="color: #74777d">/* Widgets */</span> <span style="color: #aa2211">||</span> <span style="color: #004012">tabBar</span><span class="p">.</span><span style="color: #004012">hoveredTab</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">widgetExplorer</span> <span style="color: #aa2211">=</span> <span style="color: #004012">widgetExplorerComponent</span><span class="p">.</span><span style="color: #004012">createObject</span><span class="p">(</span><span style="color: #004012">root</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't get why we are we creating this dynamically? and why on hover?</p>

<p style="padding: 0; margin: 8px;">I assume it's because WE is costly?  and doing it on hover makes it seem faster?</p>

<p style="padding: 0; margin: 8px;">but this code has a quirk that if you hover and then click (a fairly common pattern) you'll actually be creating this component twice.</p>

<p style="padding: 0; margin: 8px;">A Loader with: active: activeTab == 1 || hoveredTab ==1 would be ideal and more declarative.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12515" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DashboardRepresentation.qml:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">sourceModel:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">widgetExplorer</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">root.widgetExplorer.filterModel :</span> <span style="color: #000a65">null</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">filterCallback:</span> <span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">row</span><span class="p">,</span> <span style="color: #004012">value</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's better to just adjust Widget Explorer if we need to add functionality into WidgetExplorer</p>

<p style="padding: 0; margin: 8px;">Doing something like this is the sort of thing that's going to unnoticeably break in the future when someone re-arranges those categories.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3200#inline-12513" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DashboardTabBar.qml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">onContainsMouseChanged:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">containsMouse</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">for every mouse move you have two of these being emitted in sequence</p>

<p style="padding: 0; margin: 8px;">one from the old tab, one from the new tab.</p>

<p style="padding: 0; margin: 8px;">Can you be guarantee what order that happens in?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3200" rel="noreferrer">https://phabricator.kde.org/D3200</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, Plasma, mart<br /><strong>Cc: </strong>davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>