<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3192" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hi, <br />
I am fine with the commit (especially since it fixes a bug which I have had no time to reproduce)<br />
Now since indeed 2 more pixels are needed on top of the ones from the MenuButton_IndicatorWidth, I would be inclided to just change <br />
size.rwidth() += Metrics::ComboBox_IndicatorWidth into<br />
size.rwidth() += Metrics::MenuButton_IndicatorWidth+2 (with a comment)<br />
rather than adding a new enum in Metrics. <br />
The idea with this enum is that you can in principle change all the values without breaking anything, which is not the case here.<br />
The alternative would be to make the enum be:<br />
ComboBox_IndicatorWidth = MenuButton_IndicatorWidth+2</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rBREEZE Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3192" rel="noreferrer">https://phabricator.kde.org/D3192</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antlarr, Plasma, Plasma: Design<br /><strong>Cc: </strong>hpereiradacosta, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, htietze, sebas<br /></div>