<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3183" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>code looks good.<br />
I tested the urls, annotated inline those that work and those that don't.<br />
Unfortunately there are still two that don't, in flickr, where a no longer valid api key is used and the wikipedia one.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12357" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">apodprovider.cpp:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">K</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://antwrp.gsfc.nasa.gov/apod/"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">Q</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://antwrp.gsfc.nasa.gov/apod/"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">storedGet</span><span class="p">(</span> <span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">NoReload</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">works, +1</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12356" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">epodprovider.cpp:82</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">K</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://epod.usra.edu/blog/"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">Q</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://epod.usra.edu/blog/"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span> <span style="color: #aa2211">*</span><span class="n">job</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">storedGet</span><span class="p">(</span> <span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">NoReload</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this works, +1</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12355" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">flickrprovider.cpp:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">KUrl</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"http://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4</span>&method=flickr.interestingness.getList&date="</span> <span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">mActualDate</span><span class="p">.</span><span class="n">toString</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ISODate</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">QUrl</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"https://api.flickr.com/services/rest/?api_key=11829a470557ad8e10b02e80afacb3af</span>&method=flickr.interestingness.getList&date="</span> <span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">mActualDate</span><span class="p">.</span><span class="n">toString</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ISODate</span><span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span> <span style="color: #aa2211">*</span><span class="n">pageJob</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">storedGet</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">NoReload</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this one is valid, same api key should be used in the other queries</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12352" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">flickrprovider.cpp:129</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">K</span>Url</span> <span style="color: #004012">url</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #766510">"http://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date="</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">Q</span>Url</span> <span style="color: #004012">url</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #766510">"http<span class="bright">s</span>://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date="</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">ISODate</span> <span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">says "key has expired",<br />
should have 11829a470557ad8e10b02e80afacb3af instead?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12354" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">natgeoprovider.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http<span class="bright">://photography</span>.nationalgeographic.com/photography/photo-of-the-day"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http<span class="bright">s://www</span>.nationalgeographic.com/photography/photo-of-the-day"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mPage</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">loadFinished</span><span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">)),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">pageRequestFinished</span><span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">))</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">works, +1</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12353" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">noaaprovider.cpp:95</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QUrl</span></span><span class="bright"> </span><span class="n"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"http://photography.nationalgeographic.com/photography/photo-of-the-day</span>"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">QUrl</span></span><span class="bright"> </span><span class="n"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"http://www.nnvl.noaa.gov/imageoftheday.php</span>"</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mPage</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">loadFinished</span><span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">)),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">pageRequestFinished</span><span class="p">(</span><span style="color: #aa4000">bool</span><span class="p">))</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this one works, +1</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12351" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wcpotdprovider.cpp:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">K</span>Url</span> <span class="n">picUrl</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"</span> <span class="p">)</span> <span class="p">);</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span> <span style="color: #aa2211">*</span><span class="n">imageJob</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">storedGet</span><span class="p">(</span> <span class="n">picUrl</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">NoReload</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">Q</span>Url</span> <span class="n">picUrl</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"</span> <span class="p">)</span> <span class="p">);</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">StoredTransferJob</span> <span style="color: #aa2211">*</span><span class="n">imageJob</span> <span style="color: #aa2211">=</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">storedGet</span><span class="p">(</span> <span class="n">picUrl</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">NoReload</span><span class="p">,</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">HideProgressInfo</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">mParent</span><span style="color: #aa2211">-></span><span class="n">connect</span><span class="p">(</span> <span class="n">imageJob</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">finished</span><span class="p">(</span><span class="n">KJob</span><span style="color: #aa2211">*</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">imageRequestFinished</span><span class="p">(</span><span class="n">KJob</span><span style="color: #aa2211">*</span><span class="p">))</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">other copy of invalid url</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3183#inline-12350" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wcpotdprovider.cpp:73</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span class="n"><span class="bright">K</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"</span> <span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="bright"></span><span class="n"><span class="bright">Q</span>Url</span> <span class="n">url</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span style="color: #766510">"http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"</span> <span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this url doesn't seem to be valid anymore</p>
<p style="padding: 0; margin: 8px;">maybe should web-scrape <a href="https://en.wikipedia.org/wiki/Wikipedia:Wikimedia_Commons/POTD" class="remarkup-link" target="_blank" rel="noreferrer">https://en.wikipedia.org/wiki/Wikipedia:Wikimedia_Commons/POTD</a> ?<br />
(don't know if there is a way to obtain directly the image)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEPLASMAADDONS Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3183" rel="noreferrer">https://phabricator.kde.org/D3183</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>xuetianweng, Plasma, mart<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>