<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3086" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3086#inline-12390" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appmenu.cpp:88-89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">auto</span> <span class="n">setWindowProperty</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span class="n">c</span><span class="p">](</span><span class="n">WId</span> <span class="n">id</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span style="color: #aa2211">&</span><span class="n">name</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QByteArray</span> <span style="color: #aa2211">&</span><span class="n">value</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">const</span> <span class="n">xcb_intern_atom_cookie_t</span> <span class="n">cookie</span> <span style="color: #aa2211">=</span> <span class="n">xcb_intern_atom</span><span class="p">(</span><span class="n">c</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">,</span> <span class="n">name</span><span class="p">.</span><span class="n">length</span><span class="p">(),</span> <span class="n">name</span><span class="p">.</span><span class="n">constData</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">xcb_intern_atom_reply_t</span><span class="p">,</span> <span class="n">QScopedPointerPodDeleter</span><span style="color: #aa2211">></span> <span class="n">reply</span><span class="p">(</span><span class="n">xcb_intern_atom_reply</span><span class="p">(</span><span class="n">c</span><span class="p">,</span> <span class="n">cookie</span><span class="p">,</span> <span class="n">Q_NULLPTR</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">reply</span><span class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This causes a roundtrip every time it gets invoked. I suggest to cache the returned atom. You can just do something like:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">xcb_atom_t myAtom = XCB_ATOM_NONE;
if(myAtom == XCB_ATOM_NONE) {
    // cookie-reply-dance
    myAtom = reply->atom;
}
if (myAtom == XCB_ATOM_NONE) {
    // whoops something failed with fetching the atom
    return;
}
xcb_change_property(....)</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3086" rel="noreferrer">https://phabricator.kde.org/D3086</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, mart<br /><strong>Cc: </strong>graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>