<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129102/">https://git.reviewboard.kde.org/r/129102/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Either this patch or some other patch in the kplugin series broke the "externalData" for many applets!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Basically d->init(QString(), args.mid(2)); creates the applet with (QVariant(QVariantList, ()) argument and thus, since the args passed to init isn't empty, it emits onExternalData on the applet with this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most applets don't do anything with it but for example FolderView then sets this as its url ("cannot assign QJSValue to QString") and the FolderView becomes blank on next (or 2nd after that) startup.</p></pre>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Oktober 10th, 2016, 2:28 nachm. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Okt. 10, 2016, 2:28 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Makes it possible to use plugins that offer a metadata.json file.
Define the service type when falling back to the desktop file parser, so the type system is proper.
Don't destroy a KPluginMetadata tuple to instanciate it right away.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests still pass, plasma still loads, even with RR #129103.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/applet.cpp <span style="color: grey">(5eb529c)</span></li>
<li>src/plasma/containment.h <span style="color: grey">(0b7a3ef)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(1840f24)</span></li>
<li>src/plasma/pluginloader.h <span style="color: grey">(566461d)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(db2b2c9)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(fafb450)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129102/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>