<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128956/">https://git.reviewboard.kde.org/r/128956/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2016, 5:46 p.m. UTC, <b>Andreas Hartmetz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why not add logic to the runner to disable it automatically in the appropriate conditions? It doesn't have to be as simplistic as "there is no Baloo database at all". The other Andreas sort of suggested that and dismissed it right away but I think it's a good idea.
For example, it could be tri-state: Disabled by default if Baloo file search is disabled, enabled if file search is enabled, or explicitly enabled / disabled. While it's ugly, it also covers the case that somebody uses only E-mail indexing. E-mail indexing is super useful IME, and somebody might want to use it from krunner. I just use it from KMail, though...
One could also add an option to the Baloo KCM to clear the file index, which would automatically disable the runner (not sure if this is doable with a small amount of work / code).
I don't think it is a good idea to effectively make distributions choose Baloo support or not in krunner. If they still really want to, they can probably use the cascading feature of KConfig and supply a global config file that disables the Baloo runner by default.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, it totally makes sense to interact with the KCM setting, it's just outside the scope of this RR. To a user it is not at all obvious that they need to disable it in two places. They will just start to type in krunner or K menu with a big chance of a segfault. The KCM itself should additionally stop the indexing when being disabled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The default would always be <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">with</em> Baloo, but giving choice to disable build for certain systems is just a nice thing to do. To kind of enforce that default, one could also add a default-on option to cmake so that it continued to fail to configure with missing Baloo instead of silently build without it.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On September 20th, 2016, 12:06 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2016, 12:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regardless of the current state of Baloo, it is not very deeply tied into Plasma. Usage in plasma-workspace comes down to providing the baloo runner.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Several days of Plasma-5 without any issues. Usage of krunner without any segfaults.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9da918358bd797b8fe00de646b6576ba22976d0e)</span></li>
<li>runners/CMakeLists.txt <span style="color: grey">(48cc3799f834a57031ae387a35f41859178fe317)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128956/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>