<table><tr><td style="">graesslin added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2972" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2972#inline-11500" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:95-96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">monitorLoad</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nitpick</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2972#inline-11501" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:212</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">List</span> <span class="n">offers</span> <span style="color: #aa2211">=</span> <span class="n">KServiceTypeTrader</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">query</span><span class="p">(</span><span style="color: #766510">"KWin/Script"</span><span class="p">,</span> <span style="color: #766510">"[X-KWin-Border-Activate] == true and not (exist [X-KWin-Exclude-Listing]) or [X-KWin-Exclude-Listing] == false"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">KPluginInfo</span><span style="color: #aa2211">></span> <span class="n">scripts</span> <span style="color: #aa2211">=</span> <span class="n">KPluginInfo</span><span style="color: #aa2211">::</span><span class="n">fromServices</span><span class="p">(</span><span class="n">offers</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why are you querying KService? Scripts are packages and at least KWin internally they are queried using:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KPackage::PackageLoader::self()->listPackages(QStringLiteral("KWin/Script"), scriptFolder);</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2972#inline-11502" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:216</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">KConfigGroup</span> <span style="color: #004012">config</span><span class="p">(</span><span class="n">m_config</span><span class="p">,</span> <span style="color: #766510">"Plugins"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KPluginInfo</span> <span style="color: #aa2211">&</span><span class="n">script</span><span class="p">,</span> <span class="n">scripts</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="n">script</span><span class="p">.</span><span class="n">pluginName</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Enabled"</span><span class="p">),</span> <span class="n">script</span><span class="p">.</span><span class="n">isPluginEnabledByDefault</span><span class="p">()))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please don't add any new foreach any more. It might get deprecated</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2972#inline-11503" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:328</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">list</span> <span style="color: #aa2211">=</span> <span class="n">scriptConfig</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"BorderActivate"</span><span class="p">,</span> <span class="n">list</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span class="p">,</span> <span class="n">list</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="n">monitorChangeEdge</span><span class="p">(</span><span class="n">ElectricBorder</span><span class="p">(</span><span class="n">i</span><span class="p">),</span> <span class="n">index</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2972" rel="noreferrer">https://phabricator.kde.org/D2972</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas<br /></div>