<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129101/">https://git.reviewboard.kde.org/r/129101/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129101/diff/3/?file=481722#file481722line111" style="color: black; font-weight: bold; text-decoration: underline;">runners/windowedwidgets/windowedwidgetsrunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">name</span> <span class="o">=</span> <span class="n"><span class="hl">service</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">name</span></span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">107</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QString</span> <span class="n">name</span> <span class="o">=</span> <span class="n"><span class="hl">md</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">pluginId</span></span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Nit-picky:</em> If it's not a name, and other parts have a name, maybe we should rename this variable so that if this function ends up growing we don't have to worry about keeping this straight.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129101/diff/3/?file=481723#file481723line46" style="color: black; font-weight: bold; text-decoration: underline;">shell/alternativeshelper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_applet</span><span class="o">-></span><span class="n">plugin<span class="hl">Info</span></span><span class="p">().</span><span class="n">plugin<span class="hl">Name</span></span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">m_applet</span><span class="o">-></span><span class="n">plugin<span class="hl">MetaData</span></span><span class="p">().</span><span class="n">plugin<span class="hl">Id</span></span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Very Minor:</em> Since we're changing the meaning of what we're returning now from the human-readable name to the plugin ID from metadata, now may be a good time to add some documentation to clarify what is being returned as the current plugin.</p></pre>
</div>
</div>
<br />
<p>- Michael Stemle</p>
<br />
<p>On October 5th, 2016, 10:54 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2016, 10:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reduces unnecessary castings.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/systemtray.cpp <span style="color: grey">(e1cd610)</span></li>
<li>components/shellprivate/widgetexplorer/widgetexplorer.cpp <span style="color: grey">(c2b38a8)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: grey">(fbacbf8)</span></li>
<li>runners/windowedwidgets/windowedwidgetsrunner.h <span style="color: grey">(2294965)</span></li>
<li>runners/windowedwidgets/windowedwidgetsrunner.cpp <span style="color: grey">(5ccbd27)</span></li>
<li>shell/alternativeshelper.cpp <span style="color: grey">(d0f5dfd)</span></li>
<li>shell/containmentconfigview.cpp <span style="color: grey">(cec067e)</span></li>
<li>shell/scripting/containment.cpp <span style="color: grey">(6040e62)</span></li>
<li>shell/scripting/widget.cpp <span style="color: grey">(a651c2a)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(1d08cd1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129101/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>