<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/04/2016 10:53 PM, Peter Wu wrote:<br>
</div>
<blockquote cite="mid:20161004205344.14761.41341@mimi.kde.org"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid; border-radius: 6px;
-moz-border-radius: 6px; -webkit-border-radius: 6px;"
bgcolor="#f9f3c9" width="100%" cellpadding="12">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/128761/">https://git.reviewboard.kde.org/r/128761/</a>
</td>
</tr>
</tbody>
</table>
<br>
<blockquote style="margin-left: 1em; border-left: 2px solid
#d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2016, 12:25 p.m.
CEST, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid
#d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Congratulations with the release of Plasma 5.8! It contains the Breeze fix (yay!), but Oxygen is unfortunately lacking this patch. Could you merge it? Thanks!</p></pre>
<br>
</div>
</blockquote>
Done<br>
<blockquote cite="mid:20161004205344.14761.41341@mimi.kde.org"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<p>- Peter</p>
<br>
<p>On August 27th, 2016, 11:12 a.m. CEST, Peter Wu wrote:</p>
<table style="border: 1px #888a85 solid; border-radius: 6px;
-moz-border-radius: 6px; -webkit-border-radius: 6px;"
bgcolor="#fefadf" width="100%" cellpadding="12"
cellspacing="0">
<tbody>
<tr>
<td>
<div>Review request for Plasma, David Edmundson, David
Faure, and Hugo Pereira Da Costa.</div>
<div>By Peter Wu.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2016, 11:12
a.m.</i></p>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs:
</b> <a moz-do-not-send="true"
href="https://bugs.kde.org/show_bug.cgi?id=356940">356940</a>
</div>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" width="100%" cellpadding="10"
cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Copied from breeze patch <a class="moz-txt-link-freetext" href="https://git.reviewboard.kde.org/r/128760/">https://git.reviewboard.kde.org/r/128760/</a></p></pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Testing </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" width="100%" cellpadding="10"
cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Started <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QT_STYLE_OVERRIDE=oxygen LD_LIBRARY_PATH=... QT_PLUGIN_PATH=... wireshark -o</code> (an invalid option that triggers <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">exit(1)</code>) and observe a heap-use-after free similar to the one reported in the bug. Apply this patch, rebuild oxygen and notice that the crash is fixed. Also tested with "Testcase (ASAN)" from bug 356940, crash is also gone.</p></pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyle/oxygenstyleplugin.cpp <span style="color:
grey">(70b90d9)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/128761/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>