<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117750/">https://git.reviewboard.kde.org/r/117750/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Closing as this review request is more than 2 years old.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it still applies to current Plasma please reopen this review request. Thanks</p></pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On April 24th, 2014, 6:24 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 24, 2014, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-sdk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">populate the konsole and enable it by default in plasmoidviewer
we add a custom message handler which will print all the output to
stdout and also it will check from debug messages which come from
the category "qml" and those which are coming from QML</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoidviewer/main.cpp <span style="color: grey">(009acbbe7591b03487913cb1316d5f61e6a2b500)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <span style="color: grey">(d99c8cd8ebfbbe27ca04ba30c7a2bbe396d1a064)</span></li>
<li>plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml <span style="color: grey">(34db7f6fc6a04ce96cd307455ff15abe6697f194)</span></li>
<li>plasmoidviewer/view.h <span style="color: grey">(d997f15d093584f4446bbdb3475c30c98441e728)</span></li>
<li>plasmoidviewer/view.cpp <span style="color: grey">(aa8914539358b216b9641da679050f95ba5af512)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117750/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/8ad4291f-c8b8-4378-8ab0-0330bb01d454__plasmoidviewer_msghandler_reviewboard_ok.png">plasmoidviewer_message</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>