<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118697/">https://git.reviewboard.kde.org/r/118697/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Closing as this review request is more than 2 years old.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it still applies to current Plasma please reopen this review request. Thanks</p></pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On June 12th, 2014, 3:43 p.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated June 12, 2014, 3:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one has been pending for some time now. Our Album data model assumed that a album name is enough to uniquely identify an album. This creates problems because multiple artists may have albums with the same name.
This patch makes Media Library and ItemCache aware of this fact.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests pass. Added test to take care of the new scenario.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/album.h <span style="color: grey">(4926e48)</span></li>
<li>libs/mediacenter/album.cpp <span style="color: grey">(881f65a)</span></li>
<li>libs/mediacenter/itemcache.h <span style="color: grey">(ffee05f)</span></li>
<li>libs/mediacenter/medialibrary.cpp <span style="color: grey">(9c58b44)</span></li>
<li>libs/test/itemcachetest.h <span style="color: grey">(4fc6807)</span></li>
<li>libs/test/itemcachetest.cpp <span style="color: grey">(e6dee33)</span></li>
<li>libs/test/medialibrarytest.h <span style="color: grey">(718457d)</span></li>
<li>libs/test/medialibrarytest.cpp <span style="color: grey">(e1a8c9b)</span></li>
<li>libs/test/mediatest.cpp <span style="color: grey">(8fde60b)</span></li>
<li>libs/test/pmcalbumtest.cpp <span style="color: grey">(9f2b4c8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118697/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>