<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128997/">https://git.reviewboard.kde.org/r/128997/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 21st, 2016, 11:42 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128997/diff/1/?file=477301#file477301line90" style="color: black; font-weight: bold; text-decoration: underline;">appmenu/appmenu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">m_menubar</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if 0</span><span class="c"></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what's with this change?</p></pre>
</blockquote>
<p>On September 22nd, 2016, midnight UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The warning was saying that it's a delete of something fwd-declared. A bit more research suggested that it's <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#if 0</code>'d everywhere else. So here too.</p></pre>
</blockquote>
<p>On September 22nd, 2016, 4:53 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At line 32 topmenu is removed as include. Deleting pointer of fwrd declared class is a no-op, you can get rid of m_menubar usage at all.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i guess this is due to appmenu not really working/port half done, there were plans to resurrect it iirc?</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On September 21st, 2016, 11:36 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2016, 11:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be ok, would like your +1 nevertheless.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/plugin/timezonemodel.cpp <span style="color: grey">(efd4eb2)</span></li>
<li>applets/notifications/plugin/notificationshelper.h <span style="color: grey">(066048e)</span></li>
<li>appmenu/appmenu.cpp <span style="color: grey">(bb2e7f5)</span></li>
<li>components/shellprivate/interactiveconsole/interactiveconsole.cpp <span style="color: grey">(12f0bb0)</span></li>
<li>components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp <span style="color: grey">(2560d5d)</span></li>
<li>components/shellprivate/widgetexplorer/widgetexplorer.cpp <span style="color: grey">(be5c9dc)</span></li>
<li>dataengines/apps/appsengine.cpp <span style="color: grey">(81e8ce5)</span></li>
<li>dataengines/geolocation/geolocation.cpp <span style="color: grey">(38e106c)</span></li>
<li>dataengines/share/shareengine.cpp <span style="color: grey">(039777d)</span></li>
<li>dataengines/weather/ions/noaa/ion_noaa.cpp <span style="color: grey">(40dcd46)</span></li>
<li>drkonqi/parser/backtraceparser.h <span style="color: grey">(9728e20)</span></li>
<li>klipper/clipcommandprocess.cpp <span style="color: grey">(b6631b5)</span></li>
<li>klipper/editactiondialog.cpp <span style="color: grey">(afd7d3e)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(525ef87)</span></li>
<li>krunner/dialog.h <span style="color: grey">(a34152a)</span></li>
<li>kuiserver/progresslistdelegate.h <span style="color: grey">(0fa3d6f)</span></li>
<li>libtaskmanager/abstracttasksmodel.h <span style="color: grey">(cb6e74f)</span></li>
<li>libtaskmanager/abstracttasksproxymodeliface.h <span style="color: grey">(4c627f1)</span></li>
<li>libtaskmanager/activityinfo.cpp <span style="color: grey">(8427cfd)</span></li>
<li>libtaskmanager/flattentaskgroupsproxymodel.cpp <span style="color: grey">(8b02d57)</span></li>
<li>libtaskmanager/taskfilterproxymodel.cpp <span style="color: grey">(b2cd2b1)</span></li>
<li>libtaskmanager/tasksmodel.h <span style="color: grey">(1a7eb2c)</span></li>
<li>libtaskmanager/waylandtasksmodel.cpp <span style="color: grey">(458a0c8)</span></li>
<li>plasma-windowed/main.cpp <span style="color: grey">(de3dff8)</span></li>
<li>runners/bookmarks/browsers/chrome.cpp <span style="color: grey">(9d5e6e9)</span></li>
<li>runners/bookmarks/browsers/chromefindprofile.cpp <span style="color: grey">(925083a)</span></li>
<li>runners/bookmarks/faviconfromblob.cpp <span style="color: grey">(77512eb)</span></li>
<li>runners/kill/killrunner.cpp <span style="color: grey">(a7a7a01)</span></li>
<li>runners/shell/shellrunner.h <span style="color: grey">(29d5d3c)</span></li>
<li>runners/webshortcuts/webshortcutrunner.cpp <span style="color: grey">(1ad6677)</span></li>
<li>shell/alternativeshelper.cpp <span style="color: grey">(a96b266)</span></li>
<li>shell/containmentconfigview.cpp <span style="color: grey">(3ae2985)</span></li>
<li>shell/desktopview.h <span style="color: grey">(f72add1)</span></li>
<li>shell/panelview.h <span style="color: grey">(36c414e)</span></li>
<li>shell/scripting/scriptengine_v1.cpp <span style="color: grey">(ab33bf5)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(25e0378)</span></li>
<li>wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(8130b1c)</span></li>
<li>wallpapers/image/image.h <span style="color: grey">(c488a84)</span></li>
<li>wallpapers/image/image.cpp <span style="color: grey">(ea66733)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128997/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>