<table><tr><td style="">sebas added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2584" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2584#inline-10761" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compositing.ui:9</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <y>0</y>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <width><span class="bright">481</span></width>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <height><span class="bright">349</span></height>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <width><span class="bright">815</span></width>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <height><span class="bright">510</span></height>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">resize the window before saving, that means it saves the minimum size, rather than a random one</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2584#inline-10762" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compositing.ui:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> </property>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <property name="text">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <property name="text"<span class="bright"> stdset="0"</span>>
</div><div style="padding: 0 8px; margin: 0 4px; "> <string>OpenGL compositing (the default) has crashed KWin in the past.
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dunno where this comes from, and what it means ... also in the following places</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2584#inline-10763" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compositing.ui:290</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <string>Applications can set a hint to block compositing when the window is open.
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> This brings performance improvement for e.g. games.
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> The setting can be overruled by window specific rules.</string>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">improvements (plural)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2584#inline-10764" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">options.h:193</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">KWin</span><span style="color: #aa2211">::</span><span class="n">OpenGLPlatformInterface</span> <span class="n">glPlatformInterface</span> <span class="n">READ</span> <span class="n">glPlatformInterface</span> <span class="n">WRITE</span> <span class="n">setGlPlatformInterface</span> <span class="n">NOTIFY</span> <span class="n">glPlatformInterfaceChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">windowsBlockingCompositing</span> <span class="n">READ</span> <span class="n">isWindowsBlockingCompositing</span> <span class="n">WRITE</span> <span class="n">setWindowsBlockingCompositing</span> <span class="n">NOTIFY</span> <span class="n">windowsBlockingCompositingChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">public</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">without the is* ? (It's not required by QML, unlike Thomas suggests)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2584" rel="noreferrer">https://phabricator.kde.org/D2584</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma on Wayland, VDG<br /><strong>Cc: </strong>sebas, broulik, colomar, luebking, mart, bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts<br /></div>