<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128870/">https://git.reviewboard.kde.org/r/128870/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128870/diff/1/?file=476618#file476618line119" style="color: black; font-weight: bold; text-decoration: underline;">src/declarativeimports/plasmastyle/ToolButtonStyle.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">115</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">colorGroup:</span> <span class="nx">style</span><span class="p">.</span><span class="nx">controlHovered</span> <span class="o">||</span> <span class="o">!</span><span class="nx">style</span><span class="p">.</span><span class="nx">flat</span> <span class="o">?</span> <span class="k">PlasmaCore.Theme.ButtonColorGroup :</span> <span class="nx">PlasmaCore</span><span class="p">.</span><span class="nx"><span class="hl">Theme</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">NormalC</span>olorGroup</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">colorGroup:</span> <span class="nx">style</span><span class="p">.</span><span class="nx">controlHovered</span> <span class="o">||</span> <span class="o">!</span><span class="nx">style</span><span class="p">.</span><span class="nx">flat</span> <span class="o">?</span> <span class="k">PlasmaCore.Theme.ButtonColorGroup :</span> <span class="nx">PlasmaCore</span><span class="p">.</span><span class="nx"><span class="hl">ColorScope</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">c</span>olorGroup</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">shouldn't both be colorscoped?</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On September 9th, 2016, 9:41 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2016, 9:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes the size of the icon as well as its color group.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is no longer squashed and ugly and its color is correct on the lock screen now (white like the text)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmastyle/ToolButtonStyle.qml <span style="color: grey">(2518656)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128870/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/09/9d02ec39-2cb2-4c18-8088-aa86973daab4__Screenshot_20160909_113913.png">Fixed</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>