<table><tr><td style="">kossebau created this revision.<br />kossebau added reviewers: Plasma, mart, apol.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2726" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Currently kpackage_install_package fails if KDE_INSTALL_DIRS_NO_DEPRECATED<br />
is set to TRUE, because the macro is still using the deprecated var<br />
DATA_INSTALL_DIR<br />
It should be fine to bump the min version of ECM required to needed ECM 1.6.0,<br />
as someone using KF5 5.27 very surely also has a similar recent ECM.<br />
(Compare also recent similar patch for KF5PackageMacros.cmake)</p>
<p>Also done (will be separate commits)</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">remove unused variable KPACKAGE_DATA_INSTALL_DIR</li>
<li class="remarkup-list-item">fix api dox for default value of install_dir</li>
</ul></div></div><br /><div><strong>BRANCH</strong><div><div>supportKDE_INSTALL_DIRS_NO_DEPRECATED</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2726" rel="noreferrer">https://phabricator.kde.org/D2726</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>KF5PackageMacros.cmake</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, Plasma, mart, apol<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>